Re: reworked web search

On Sun, May 25, 2014 at 10:44:54AM +0100, Chris Young wrote:
> On Sun, 25 May 2014 10:11:39 +0100, Vincent Sanders wrote:
>
> > On Sun, May 25, 2014 at 09:59:30AM +0100, Chris Young wrote:
> > > On Sun, 25 May 2014 01:10:56 +0100, Vincent Sanders wrote:
> > >
> > > > I have fixed up both GTK and Amiga usage (apologies to chrisy if I
> > > > made an error in amiga)
> > >
> > > I have no icon and attempting to search results in an "InitFailed"
> > > error message. Any ideas?
> >
> > This will stem from the search_web_init() not suceeding or being
> > called at all. It should be called once in the initialisation process
> > preferably after the fetchers have been initialised (after
> > netsurf_init). However I thought i did this already for amiga.
>
> Fixed, thanks.
>
> The search is behaving oddly - I'm getting two (and always two)
> garbage characters on the end of my search string. So, if I search
> for netsurf on Google I get something like:
> http://www.google.com/search?q=netsurfO%FC

hmm. that is strange (honest i did test this with the gtk frontend!)
is this soemthing to do with how the search term is extracted on
amiga? search_web_omni() is supposed to take the search term it is
given and substitute it into the search url.

It may be worth adding logging of the pass term and the search url in
search_web_omni() to check where the problem lies.

It is possible that the code that parses the loaded search providers
file (in desktop/searchweb.c) is not parsing the search provider urls
correctly, although it is doing simple strchr calls using | as a field
separator which ought to be more robust than the previous code.

>
> > There may be an issue with retrieving the default icon (now done
> > through a standard resource:default.ico fetch) I thought the init
> > should cope with not having access to the icon but I may be mistaken.
>
> Don't know, but I've mapped it across now. It seems to be using the
> default icon at startup some of the time, so there's some odd timing
> issue there.

The way this is supposed to operate now is that on initialisation the
resource:default.ico is fetched. Whenever a new provider is selected
with a call to search_web_select_provider() the provider_update
callback is called.

If the providers icon has not already been fetched a fetch is started
and the default bitmap is passed to the callback, once the provider
icon fetch successfully completes the callback is again called to
update with the new bitmap.

>
> Chris
>
>

--
Regards Vincent
http://www.kyllikki.org/