Re: reworked web search

On Sun, May 25, 2014 at 03:12:01PM +0100, Chris Young wrote:
> On Sun, 25 May 2014 11:32:42 +0100, Vincent Sanders wrote:
>
> > > The search is behaving oddly - I'm getting two (and always two)
> > > garbage characters on the end of my search string. So, if I search
> > > for netsurf on Google I get something like:
> > > http://www.google.com/search?q=netsurfO%FC
> >
> > hmm. that is strange (honest i did test this with the gtk frontend!)
> > is this soemthing to do with how the search term is extracted on
> > amiga? search_web_omni() is supposed to take the search term it is
> > given and substitute it into the search url.
>
> I've fixed it, the URL wasn't getting NULL-terminated. I guess on
> your test platform the memory allocation was zeroed, but here it
> wasn't.
>

Thankyou very much Chris!. Dumb error on my part, sorry about
that.

May I ask if (aside from the dumb mistakes) the feature is working as
expected now? It ought to have removed any delays if the network was
unable to fetch the search providers icons and made the whole thing
more robust.

I do not know if you are aware of the search_url_bar boolean option
which is supposed to control search behaviour on input to the
search_web_omni() operation.

The heuristics for deciding if a search term is a url are still a
little inadequate but I am working on them. This should eventually
allow us to have a url bar which mostly does the right thing and
perhaps a simple additional button for "search for this term, do not
try to interpret as a url"

--
Regards Vincent
http://www.kyllikki.org/