On Mon, Mar 17, 2014 at 17:08:28 +0000, Vincent Sanders wrote:
> Overall I like the feature, hell if it were not for libidn2 I would
> have already merged it. Perhaps someone else has an opinion better
> thought through than mine.
If libidn2 were less GNUy I'd be saying "go for it" too.
Also, I'd like to see a proper patch series posted, with a clean git branch
behind it, before I cast an opinion on the code itself. We need (as a project)
to get better at clean patch series :-)
D.
--
Daniel Silverstone http://www.netsurf-browser.org/
PGP mail accepted and encouraged. Key Id: 3CCE BABE 206C 3B69
No comments:
Post a Comment