Re: [PATCH] Cover: Entities Patch without tests

On Tue, Mar 11, 2014 at 23:50:33 +0530, rsk1994 wrote:
> The last commit in mybranch3 here is the latest one. Here is the link to commit with the tests.:
> https://bitbucket.org/rupindersingh/libhubub/commits/6c23ec65560bdebec831e313200d6887ab2ca355

This is a good way to start your message. I'd like to start encouraging reviews to begin in the form:

Repo: libhubbub
sURL: https://bitbucket.org/rupindersingh/libhubub.git
sRef: mybranch3
SHA1: 6c23ec65560bdebec831e313200d6887ab2ca355
Land: master

To indicate this is for libhubbub, the source URL to fetch from (not needed if
on git.netsurf-browser.org) the source ref the merge will use, the SHA1 of the
tip of that branch and the branch it's intended to land on.

Most of that information was derivable from what you said, so you gave the
useful data, but the landing branch was implicit.

Also, you would do well to learn to name your branches more effectively than
'mybranch3' which is not at all descriptive to those of us looking to merge
your code.

Perhaps something more like 'better-entity-support' would be a good name?

D.

--
Daniel Silverstone http://www.netsurf-browser.org/
PGP mail accepted and encouraged. Key Id: 3CCE BABE 206C 3B69