Wednesday, 4 March 2015

Re: [gccsdk] Building LibGetText

Hi Theo

On 04/03/2015 02:06, Theo Markettos wrote:
On Tue, Mar 03, 2015 at 08:15:28PM +0000, John Ballance wrote:  
Hi    Trying to get to the point of building things word aligned, since  more modern cpus do not give the historical nonaligned behaviour.    autobuilder patch enclosed lets me get past the repeated time.h  error in libraries.gettext  
  Apologies for being nitpicky, but can you reduce that patch?  It looks  sensible, but there's a lot of whitespace changes that mean the patch is  much larger than it need be.  Larger patches are less likely to continue to work  if upstream changes.  Better just to attach the patch without zipping it,  that makes it easier to pull off the list archives (I can force Jenkins to  wget it directly from there, as a hacky way to test patches on a vanilla  install before committing).
The gist of the patch is to enclose the whole script in
+#ifndef _C@GUARD_PREFIX@_SYS_TIME_H_SEEN_
+# define _C@GUARD_PREFIX@_SYS_TIME_H_SEEN_
...
+

No comments:

Post a Comment