[RFC] Bug 2182--revised patch

>From aecce8ffbc596bf62d2cf9609f35c1e1c1a28077 Mon Sep 17 00:00:00 2001
From: David Gee <dr_d_gee@blueyonder.co.uk>
Date: Sun, 15 Mar 2015 17:30:50 +0000
Subject: [PATCH] Stop unneccessary closure of menu tree when asked for
clipboard data. Currently, when asked for clipboard data, Netsurf
unconditionally closes the menu tree of the requesting application. This
occurs in the routine ro_gui_send_datasave. There is no reason to close the
menu tree: this function is called in only one place, amd the code path is
through Wimp user messages-- the highest priority type of message, so other
interactions cannot interfere. The fix removes the line which closes the menu
tree in this particular function.

---
riscos/save.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/riscos/save.c b/riscos/save.c
index b5d96c4..c4fd839 100644
--- a/riscos/save.c
+++ b/riscos/save.c
@@ -723,7 +723,7 @@ void ro_gui_send_datasave(gui_save_type save_type,
{
/* Close the save window because otherwise we need two contexts
*/
- xwimp_create_menu(wimp_CLOSE_MENU, 0, 0);
+
ro_gui_dialog_close(dialog_saveas);

if (ro_message_send_message(wimp_USER_MESSAGE_RECORDED, (wimp_message*)message,
--
1.9.1

Attached is a revised patch for bug 2182. This time with more detailed
comments. Hope this is suitable and in the correct format.

--
David Gee
Gateshead