Saturday, 14 March 2015

Re: Bug 2182

David Gee <dr_d_gee@blueyonder.co.uk> wrote:

>I've looked at Bug 2182 and made appropriate modifications to
>riscos/save.c. This wasn't *too* tricky since the identifier of the bug
>also suggested how it might be solved.

Poking my nose in where it's probably not welcome... I peeked at the diffs
just to see what they look like. In the first one there's a pair of lines

- xwimp_create_menu(wimp_CLOSE_MENU, 0, 0);
+ wimp_create_menu(wimp_CLOSE_MENU, 0, 0);

If that means you deleted the first line and added the second, I'm curious
why the second doesn't have an 'xwimp' call? Wouldn't a failure to create
the menu (unlikely, perhaps) cause an unhandled error?

--
Jeremy C B Nicoll - my opinions are my own.

No comments:

Post a Comment