Re: BoxConvert?

On Sat, 07 Jun 2014 19:58:41 +0100, Richard Torrens (lists) wrote:

> After a bit more experimenting, it is caused by the line:
>
> <P><a href="http://<!--#echo var="HTTP_HOST" --><!--#echo
> var="DOCUMENT_URI" -->">Top of page</a>

Ah, right. I know exactly what the problem is and what causes it.

NetSurf now rejects invalid URLs. By "invalid" I mean, anything
containing characters that are not permitted either in old-style ASCII
names, or in IDNA, plus some other validity checking mostly related to
IDNs.

Previously NetSurf would percent-encode the host and return that, so
you'd end up with a garbage URL. Now it rejects the URL outright.
However, it appears the layouting can't cope with that. I did some
extensive searching when I made this change initially and was unable
to track down why this was causing the layouting to fail - ideally, a
broken URL shouldn't cause termination of the layouting process, it
should only make the problem link go nowhere.

I considered this low risk at the time as it is incredibly rare to
encounter a link to a URL which doesn't conform to the rules.

However, obviously it does need to be fixed, so if you can raise it on
the bugtracker that'd be grand.

Chris