Thursday, 2 August 2012

Re: Amiga and BeOS front end selection/clipboard handling

On 2 Aug 2012 17:30:23 +0100, Chris Young wrote:

> On Thu, 02 Aug 2012 15:41:17 +0100, Michael Drake wrote:
>
> > I've removed the use of render/box.h from most front ends' selection and
> > clipboard handling.
> >
> > This meant stopping the front ends from using selection_traverse(), which
> > will be removed from the header file, and made static in
> > desktop/selection.c.
> >
> > The Amiga and BeOS front ends remain.
> >
> > We need to work out what is required on these platforms so that this can
> > happen without breaking those builds.
>
> I think I use it in context_menu.c too, but again that's purely to get
> the text contained in a selection.

Should have read the commit logs first.

I think the only thing which might cause a problem is
ami_selection_to_text(), which converts a selection to a string. This
is used in two places:

1. For context menu item "search web for highlighted text"
2. When the user drags and drops a text selection onto a non-core
gadget (either the URL bar or the web search gadget)

The other instances can be replaced with the new
selection_copy_to_clipboard()

Chris

No comments:

Post a Comment