On Sun, 29 Jul 2012 11:29:20 +0100, Daniel Silverstone wrote:
> Your maintaining of a chris/amiga-hubbub-lib-compat branch is driving a lot of
> us crazy. Firstly because you create a bunch of commit messages for "keeping
> up" with master and secondly because you managed to corrupt master with your
> "compat" change.
>
> I have resynchronised master of libdom with master of hubbub to un-do your change.
Sorry, that was accidental, for some reason when I changed the branch
it pushed to master even though I was working on my branch (I haven't
been on master at all - except to fix it after my retry to ensure it
wasn't me being on the wrong branch).
I think it might be related to the pushing changes you suggested
recently as I haven't changed anything else in Git's config and it was
working previously. I'm not sure what I need to type to undo that
though.
> Why are you maintaining some kind of 'compat' branch at this point? We've
> never made an ABI/API commitment and as such we're shouldn't be trying to
> maintain "compatibility" not least of which because there's no way for a modern
> libhubbub to know that you're not passing a script callback anyway so it'll
> jump off into oblivion given the opportunity.
>
> Unless you have a really *really* good reason for this, I ask that you stop
> maintaining these branches because they're clearly causing you confusion at
> times; and they're definitely causing us confusion/annoyance.
It's basically so I can run 2.9 and 3.0 with the same hubbub, I was
going to ditch it once 3.0 became stable enough to use. I'll fix 2.9
so it works with the new one, probably less hassle anyway.
I daren't delete my branch until I've reverted Git's config and tested
that my commits are going to the right place again.
Chris
No comments:
Post a Comment