Re: GC / remove global object, was: Patch: avoid repeated initialization/allocation of global object in js_newcompartment

On Tue, Jul 03, 2012 at 01:13:16AM +0200, Ole wrote:
> Here is the branch patch:
> http://git.netsurf-browser.org/?p=netsurf.git;a=blobdiff;f=javascript/jsapi.h;h=25175aa28b2099913d94b05134a5acaf66850329;hp=ac5ada79cece3cf05c2223df6fdb86fed667d747;hb=7d9a5844f9005bceca9337b592d80e30efde8157;hpb=e205f0f99e0cb6ffa0044c6c1322f5da8f795183;ds=sidebyside
>
> Sorry, I don't know how to diff agains master, yet. Sorry, the next
> time I will submit such thing as an diff file.

Easiest way is just git diff origin/master my/branch

The reason for 'origin' is just to make sure you diff against the master which
you pulled from the server, rather than anything else.

Alternatively you can do 'git format-patch' and it can construct patch mails
for you.

There's also 'git send-email' (might need an additional package on some OSes)
which helps you to turn patch series into mails to a list for review.

I'll be going over those things when I come to submitting something for review
in a little while. (Probably some DOM work)

D.

--
Daniel Silverstone http://www.netsurf-browser.org/
PGP mail accepted and encouraged. Key Id: 3CCE BABE 206C 3B69