>> I have not yet merged any of the pre 1.8.0 version jsapi.h macro
>> changes as I beleive as I continue to add functionality I will be
>> breaking them :-/
I have no problems with version 1.7 - no crashes or such.
Are you using my spidermonkey-1.7 branch? It's not in sync with
the master so you need pull in commits of the master.
AFAIK JS_VERSION isn't defined by any of the jsapi <= 1.7 includes.
spidermonkey >= 1.8 defines JSVERSION_LATEST, which is probably
used to define JS_VERSION.
With spidermonkey <= 1.7 you have to define JS_VERSION in the
OS_CONFIG file. I don't know if these flags are saved in some header
file. I pass JS_VERSION manually to programs that get linked against
libsjs and need the macro.
About the missing merges:
personally I would vote for merging the changes as soon as possible
into master.
This will ease the "maintainers" of the spidermonkey-1.7-support
tree to track new commits. Otherwise the diffs will get
larger and larger...
If there is really now way to integrate the branch "soon",
then it looks like we have (the need for) an fork,
and I don't know if I want to care about such fork,
because it means to pull in master commits into the fork within time.
Personally I don't think it's a good idea that the branches will drift
away from each other....
Greets,
Ole
No comments:
Post a Comment