Friday, 19 October 2012

Re: Request for feedback

On Fri, 19 Oct 2012 23:18:31 +0100, John-Mark Bell wrote:

> Build #512 contains libcurl 7.28.0. I'd appreciate it if you could a)
> test this and b) ensure that the patches I made to make libcurl build
> are sane.

The good news is that libcurl seems to be working correctly (and the
patches look as sane as expected), but that hasn't resolved the
initial problem.

I changed my local regex to be TRE recently, with the expectation that
would break my local build (I had weird effects with various regex
libraries when I first started porting NetSurf), but it didn't, so it
isn't that either.

However, I have just remembered something - I've had odd problems with
libiconv combinations, and ended up settling on linking lpu against
libiconv, but using the built-in clib iconv functions for NetSurf
itself. I *think* that lpu linked against clib iconv may have caused
NetSurf to freeze on certain pages (which is what I'm seeing on this
one). My makefile.config.override contains:
LDFLAGS += -liconv
Which clearly isn't the default, so probably the next thing to try.

> Sadly, it appears that whatever changes were made to produce the
> 7.26.0
> lha on os4depot haven't made it into upstream libcurl (and a cursory
> glance around Google doesn't reveal anything useful). I've done the
> bare
> minimum to make it build for AOS4, but I've zero expectation that it
> actually works.

The person who usually builds new versions is too lazy to submit
patches upstream. I have suggested a number of times that it will
save time in the long run. I think he just rips out most of the
Amiga-specific code so it links and uses the clib functions. I'm not
entirely sure of the sanity of libcurl, as certain #defines pick clib
functions, and others pick bsdsocket.library functions. I wouldn't
be surprised if we end up with a horrible mix. I did pick it apart
once to ensure it would build wholly against clib or bsdsocket, but
dropped it when it didn't fix the threaded resolver problem.

Chris

No comments:

Post a Comment