Re: libhubbub parse error on google homepage

Yeah sorry, I will submodule the stuff soon-ish, however there were a few things that can't be easily submoduled, like the entities.inc & aliases.inc which were generated from a perl script.  I can't count on perl being on the system, or in the path.  The build system is the nodejs standard, node-gyp so it's easier if makefiles are not used in this case.  The user will simply do a "npm install hubbub" and node-gyp would download, compile, and install the binaries.

What are your suggestions regarding some of these things?

On Fri, Oct 26, 2012 at 5:34 AM, Daniel Silverstone <dsilvers@netsurf-browser.org> wrote:

On Fri, Oct 26, 2012 at 02:45:01AM -0700, Dean Mao wrote:
> Btw, thanks for the help on this.  The project is for a nodejs native
> extension that brings the love of libhubbub to the nodejs world:
>
> https://github.com/deanmao/node-hubbub
>
> There are other html parsers in the nodejs world, but none are as good as
> libhubbub.  I considered using the parser from webkit or firefox, but
> libhubub was definitely the easiest to use since it was completely
> standalone and used very few external libraries.

I am concerned that you blithely embed an arbitrary version of our libraries
into your codebase.  While there's nothing legally wrong with doing this, from
a technical point of view it's bad for traceability.  Also it means that if
your users run into problems, tracking it back to whether or not there has been
a fix in the real hubbub codebase will be pretty hard.

If you're not going to submodule our repositories (and I can appreciate that
there's reasons why you might not want to) then you should at least indicate
which SHA1 you got hubbub and libparserutils from, so that you can track things
back later for when the parser etc move on.

D.

--
Daniel Silverstone                       http://www.netsurf-browser.org/
PGP mail accepted and encouraged.            Key Id: 3CCE BABE 206C 3B69