Sunday, 3 March 2024

[netsurf-dev] Re: [PATCH] test: nsgif: make failing tests fatal

On 2024-02-16 12:49:15, matoro wrote:
> Right now, failing tests is not currently considered fatal, and also the
> definitions of "error" vs "failure" are reversed from how they are
> usually intended. This corrects the usage and makes any instance of
> either fatal.
>
> See: https://github.com/gentoo/gentoo/pull/35142

I tend to agree with this choice of names ("error" for decoding failed
and "failure" for output other than expected), but I also noticed that
the same scheme is in use in libsvgtiny's test suite. Is copy/paste to
blame, or are the existing name choices simply as intended?

No comments:

Post a Comment