Wednesday, 13 March 2024

[netsurf-dev] Re: netsurf: branch jmb/ssl-purge created. release/3.11-16-g6bb70e881

On 11/02/2024 19:41, John-Mark Bell wrote:
> On 09/02/2024 12:24, Michael Orlitzky wrote:
>> On Thu, 2024-02-08 at 20:48 +0000, John-Mark Bell wrote:
>>>
>>> This builds fine for me against both OpenSSL 1.1.1 and 3.x. All our SDKs
>>> contain 3.x so CI builds that use it should also be fine. However, I've
>>> not actually tested LibreSSL and I believe at least one of the Amiga
>>> builds uses AmiSSL.
>>>
>>> Can people who care about these things take a look at this change and
>>> ensure it works for you?
>>>
>>
>> I asked the reporter of,
>>
>>    https://bugs.netsurf-browser.org/mantis/view.php?id=2855
>>
>>
>> if he could test it, and it's confirmed working with libressl-3.8.2.
>
> Great, thanks! I had to revert the merge, however, as certain of our CI
> builders need upgrading first. Once that's done, I'll try again!

Done, and successfully reapplied.


J.

Tuesday, 5 March 2024

[netsurf-dev] Re: Improve french translation

On 19/02/2024 15:12, Étienne Deparis wrote:
> Hi there,
>
> Since a few weeks I've been working on improving the french translation
> of the browser.
>
> Being a Linux user, I've been more involved in the gtk3 frontend,
> however I tried to also review strings for other frontends as well. What
> I mean is that I've only take care to compile and visually check the
> result of my changes with a gtk3 build, and thus cannot guarantee my
> other fixes respect the display on other systems (utf8 support, string
> length, wording habbit…). I'd be very happy to improve my copy with any
> feedback.
>
> You can find these changes under the two following patches (may be
> applied in any order):
>
> - for FatMessages:
>  https://git.umaneti.net/netsurf/patch/?id=a95d5cabb787a9b6116045d334bb0781022a65ab
> - for builtin html pages:
>  https://git.umaneti.net/netsurf/patch/?id=0169b12fc8ca2ea9607da8465817b398f999980b
>

Thank you for these -- they have been applied in:

https://git.netsurf-browser.org/netsurf.git/commit/?id=5bb2e9de3c3787d9425c1c8ba39802c75711c380

and

https://git.netsurf-browser.org/netsurf.git/commit/?id=583ec7268083fa2f4005067e0314ff9a56e62664

respectively.

> I also maintain a branch (including the previous patches) with other
> translation related improvement (like allowing the translation of the
> gtk3 history, cookies and bookmark windows, or the infopage
> widget).
>
> Let me know if I can already transmit those patches as well or if you
> prefer digest them one at a time (all my changes are in atomic commit,
> but order might be import).

If they're independent of each other, by all means send them over as-is.
Alternatively, if there are ordering constraints, let us know and I
expect we can work with that, too.

Many thanks,


John-Mark.

Sunday, 3 March 2024

[netsurf-dev] Re: [PATCH] test: nsgif: make failing tests fatal

On 2024-02-16 12:49:15, matoro wrote:
> Right now, failing tests is not currently considered fatal, and also the
> definitions of "error" vs "failure" are reversed from how they are
> usually intended. This corrects the usage and makes any instance of
> either fatal.
>
> See: https://github.com/gentoo/gentoo/pull/35142

I tend to agree with this choice of names ("error" for decoding failed
and "failure" for output other than expected), but I also noticed that
the same scheme is in use in libsvgtiny's test suite. Is copy/paste to
blame, or are the existing name choices simply as intended?