Hi guys!
I've recently implemented dark mode for Netsurf. Basically inverting white and black colors to avoid eye-strain. There are 3 options - None(by default), Preserve Colors(tries to invert just black and white, avoiding inverting bright colors), Full(just inverts everything). It works well for me, and I'm using this solution on all machines I've got NSGTK3 built. Here is the patch: https://gitlab.com/megastallman/netsurf_dark_mode/-/raw/main/DarkMode.patch
But still there is a problem with GTK3: https://ibb.co/cbXTm8h
The combobox behind the "Dark Mode" label looks empty before I click it, thus options are saved well and persist through the browser launches. Also, probably we need to make "Netsurf Preferences" form bigger to fit all controls.
Please help me fix those issues, and probably provide some upstreaming guidelines.
I've recently implemented dark mode for Netsurf. Basically inverting white and black colors to avoid eye-strain. There are 3 options - None(by default), Preserve Colors(tries to invert just black and white, avoiding inverting bright colors), Full(just inverts everything). It works well for me, and I'm using this solution on all machines I've got NSGTK3 built. Here is the patch: https://gitlab.com/megastallman/netsurf_dark_mode/-/raw/main/DarkMode.patch
But still there is a problem with GTK3: https://ibb.co/cbXTm8h
The combobox behind the "Dark Mode" label looks empty before I click it, thus options are saved well and persist through the browser launches. Also, probably we need to make "Netsurf Preferences" form bigger to fit all controls.
Please help me fix those issues, and probably provide some upstreaming guidelines.
No comments:
Post a Comment