Re: [Rpcemu] [PATCH] RPCEmu XDG-BaseDir support

On Tue, 2020-09-22 at 17:39 +0100, Peter Howkins wrote:
> On Tue, 22 Sep 2020 at 16:17, Steven Newbury <steve@snewbury.org.uk>
> wrote:
> > On Tue, 2020-09-22 at 16:00 +0100, Steven Newbury wrote:
> > > I thought I'd add RPCEmu to my Gentoo overlay, but given it only
> > > supports a hard-coded data path it doesn't lend itself to
> > packaging
> > > for
> > > system-wide installation on *NIX. So I've added support for
> > multiple
> > > search directories and XDG-BaseDir through libxdg-basedir.
> > >
> > Just noticed I didn't finish removing the fixed stack allocated
> > filename buffers. Probably not the only issues. Please let me
> > know if
> > there's anything else to fix.
>
> Hello Steven, I'm afraid there are fundamental issues with this that
> means I'm not interested in merging this approach, or any derived
> from it at this point.
>
Anything specific? Using XDG-BaseDir is the Standard approach to
solving this on Linux. I deliberately kept that code in rpc-machdep-
xdg.c, and just expanded the the file handling in the generic code to
accomodate multiple paths, while making sure it still worked as before
if only "./" exists. There is support also in qt5, but that would mean
using qt outside of the GUI support code, which would mean C++.

> There are many issues that need to be resolved for systemwide install
> on multiple platforms and your method actually adds more problems
> than it solves.

It works for me. What are the systemwide install issues? I'm happy to
look at them since I'm quite familiar with the code now after hacking
on this for a couple of days.



_______________________________________________
RPCEmu mailing list
RPCEmu@riscos.info
http://www.riscos.info/cgi-bin/mailman/listinfo/rpcemu