On Tue, 22 Sep 2020 at 18:08, Steven Newbury <steve@snewbury.org.uk> wrote:
On Tue, 2020-09-22 at 17:39 +0100, Peter Howkins wrote:
> On Tue, 22 Sep 2020 at 16:17, Steven Newbury <steve@snewbury.org.uk>
> wrote:
> > On Tue, 2020-09-22 at 16:00 +0100, Steven Newbury wrote:
> > > I thought I'd add RPCEmu to my Gentoo overlay, but given it only
> > > supports a hard-coded data path it doesn't lend itself to
> > packaging
> > > for
> > > system-wide installation on *NIX. So I've added support for
> > multiple
> > > search directories and XDG-BaseDir through libxdg-basedir.
> > >
> > Just noticed I didn't finish removing the fixed stack allocated
> > filename buffers. Probably not the only issues. Please let me
> > know if
> > there's anything else to fix.
>
> Hello Steven, I'm afraid there are fundamental issues with this that
> means I'm not interested in merging this approach, or any derived
> from it at this point.
>
Anything specific?
If I'm reading it right
1) You can no longer run more than one copy of RPCEmu using different settings
2) You're using XDG data directories that include system paths for things. This breaks horribly on multi-user systems, users shouldn't be sharing logs, config files, ide discs, hostfs, cmos files. About the only thing that could theoretically be shared is the ROM, as it's read-only, but as it's only one thing I can live with that also being a per-user-per-configuration thing.
3) You broke windows and macos (but that's a relatively small fix up)
4) By allowing the related config and files for a machine to be stored in separate directories on a system you lose the ability to keep them grouped for future multi-machine aware rpcemu (admittedly you wouldn't have been aware of that).
Peter
No comments:
Post a Comment