Re: nsgenbind crash

On Thu, 8 Nov 2012 01:07:24 +0000, Vincent Sanders wrote:

> On Wed, Nov 07, 2012 at 10:50:04PM +0000, Chris Young wrote:
> > On Wed, 7 Nov 2012 22:43:43 +0000, Vincent Sanders wrote:
> >
> > > the tool generates output using positional format specifiers like %1$d
> > > which your c library apariently cannot cope with...i will change this
> > > to normal ones for you
>
> commited,

Hmm, still seems to be adding $s and $d. I don't think I'm getting as
many errors though, so you've probably just missed one.

> along with compatability macro magic that *might* mean 1.7
> works in mainline
>
> javascript/jsapi.h now has a 1.7 section which should be updated with
> stuff i got wrong ;-)

Getting there. I think jsapi.h is ok, but the generated window.c has
some "trace" stuff in it which 1.7 doesn't like. I can get it to
build by commenting it out, but I'm not sure how important it is or
what it does:

build-amiga-amiga/window.c:27: error: expected ) before * token
build-amiga-amiga/window.c:33: error: JSCLASS_MARK_IS_TRACE undeclared here (not in a function)
build-amiga-amiga/window.c:45: error: jsclass_mark undeclared here (not in a function)
build-amiga-amiga/window.c: In function jsapi_property_window_get:
build-amiga-amiga/window.c:511: warning: implicit declaration of function JS_SET_RVAL
build-amiga-amiga/window.c: At top level:
build-amiga-amiga/window.c:2479: error: expected ) before * token

I think JS_SET_RVAL should be JSAPI_SET_RVAL though.

Thanks
Chris