Re: netsurf: branch chris/frame-scroll updated. 9a1a1209be4461eb3b7ff40eed23aa35ab0c54e2

In message <E1TZm2Z-0007FO-3T@flounder.pepperfish.net> you wrote:

> Gitweb links:
>
> ...log http://git.netsurf-browser.org/netsurf.git/shortlog/9a1a1209be4461eb3b7ff40eed23aa35ab0c54e2
> ...commit http://git.netsurf-browser.org/netsurf.git/commit/9a1a1209be4461eb3b7ff40eed23aa35ab0c54e2
> ...tree http://git.netsurf-browser.org/netsurf.git/tree/9a1a1209be4461eb3b7ff40eed23aa35ab0c54e2
>
> The branch, chris/frame-scroll has been updated
> via 9a1a1209be4461eb3b7ff40eed23aa35ab0c54e2 (commit)
> via 61241b731c4d92ed2dc77beb262645cea1593fdb (commit)
> via bb260da36e2408421c548f93cbfd28fc0052f50f (commit)
> via 64226af7488440725041e2ab1034cc735f16bb21 (commit)
> via e310dac092797fa34008fea203a07291f5838ba1 (commit)
> via 6589c7cc196863d0d0694d6bd14c39386b27ae81 (commit)
> via 82cae102843de3f9d638648556592cf9d09c9638 (commit)
> via e36b8f657997ffca3d1cc1fe1a7130854d247262 (commit)
> via c5fb16d56df03580d99fae44d9fea44868f33cc5 (commit)
> via d1a5c738e62a9f0cb85658b435eefa8749006edc (commit)
> from 78e460e4bdfdfb1daed9a9549381f3e742ba4786 (commit)
>
> Those revisions listed above that are new to this repository have
> not appeared on any other notification email; so we list those
> revisions in full, below.
>
> - Log -----------------------------------------------------------------
> commitdiff http://git.netsurf-browser.org/netsurf.git/commitdiff/9a1a1209be4461eb3b7ff40eed23aa35ab0c54e2
> commit 9a1a1209be4461eb3b7ff40eed23aa35ab0c54e2
> Author: Chris Young <chris@unsatisfactorysoftware.co.uk>
> Commit: Chris Young <chris@unsatisfactorysoftware.co.uk>
>
> debug
>
> [...]
> -/* Menu event handlers: */
> -static void __CDECL menu_about(WINDOW *win, int item, int title, void *data)
> +static void __CDECL menu_about(short item, short title, void *data)
> {
> LOG(("%s", __FUNCTION__));
> char buf[PATH_MAX];
> strcpy((char*)&buf, "file://");

Why not simply: strcpy(buf, "file://") ?

> - strncat((char*)&buf, (char*)"./doc/README.TXT", PATH_MAX - (strlen("file://")+1) );
> + strncat((char*)&buf, (char*)"./doc/README.TXT",

Why you need a char * cast of a const string ? We have
"char *strncat(char *, const char *, size_t)" so there is no need for
the 2nd char * cast.

> + PATH_MAX - (strlen("file://")+1) );
> browser_window_create((char*)&buf, 0, 0, true, false);

But more importantly, why not a simple
browser_window_create("file://./doc/README.TXT", 0, 0, true, false); ?

John.
--
John Tytgat
joty@netsurf-browser.org