Monday, 5 November 2012

Patch: toolchain / mintlib - use malloc for regex API

diff --git a/m5475-atari-mint/recipes/patches/mintlib/configvars.p b/m5475-atari-mint/recipes/patches/mintlib/configvars.p
index a135aa6..f72d6f4 100644
--- a/m5475-atari-mint/recipes/patches/mintlib/configvars.p
+++ b/m5475-atari-mint/recipes/patches/mintlib/configvars.p
@@ -1,5 +1,5 @@
---- configvars 2012-10-11 16:56:15.000000000 +0100
-+++ configvars 2012-10-11 16:57:32.000000000 +0100
+--- ./configvars.orig 2012-05-03 19:26:10.000000000 +0200
++++ ./configvars 2012-11-05 23:03:52.000000000 +0100
@@ -12,14 +12,14 @@
# get installed. You have to take car yourself that the libraries
# and include files and so on will get installed in the right place
@@ -26,3 +26,12 @@
else
prefix=/usr
endif
+@@ -124,7 +124,7 @@
+ CFLAGS=-O2 -fomit-frame-pointer
+
+ # Additional defines.
+-DEFS=
++DEFS=-DREGEX_MALLOC
+
+ # Define this to the warning level you want.
+ WARN=-Wall
diff --git a/m68k-atari-mint/recipes/patches/mintlib/configvars.p b/m68k-atari-mint/recipes/patches/mintlib/configvars.p
index e6c573b..1df9fae 100644
--- a/m68k-atari-mint/recipes/patches/mintlib/configvars.p
+++ b/m68k-atari-mint/recipes/patches/mintlib/configvars.p
@@ -1,5 +1,5 @@
---- configvars 2011-05-13 22:50:17.000000000 +0100
-+++ configvars 2011-05-13 22:57:13.000000000 +0100
+--- ./configvars.orig 2012-05-03 19:26:10.000000000 +0200
++++ ./configvars 2012-11-05 22:34:07.000000000 +0100
@@ -12,7 +12,7 @@
# get installed. You have to take car yourself that the libraries
# and include files and so on will get installed in the right place
@@ -7,9 +7,9 @@
-#CROSS=yes
+CROSS=yes

- # Define this to "m68k-atari-mint-" if you cross compile.
- ifeq ($(CROSS),yes)
-@@ -44,7 +44,7 @@
+ # Silent build or verbose
+ AM_DEFAULT_VERBOSITY = 1
+@@ -47,7 +47,7 @@
# need be. When cross-compiling you will usually want to set this
# to "/usr/m68k-atari-mint".
ifeq ($(CROSS),yes)
@@ -18,3 +18,12 @@
else
prefix=/usr
endif
+@@ -124,7 +124,7 @@
+ CFLAGS=-O2 -fomit-frame-pointer
+
+ # Additional defines.
+-DEFS=
++DEFS=-DREGEX_MALLOC
+
+ # Define this to the warning level you want.
+ WARN=-Wall
Hello,

the attached patch patches configvars file of mintlib, so that
the posix regex module is compiled with malloc instead of alloca.

This is important because some websites caused an stack overflow when
alloca was used (these pages caused the regex module to use about 3MB
of memory...)

The pages which caused this, had VERY (several kb) long URL's for CSS
retrieval
(yahoo.com was one of them).

This behavior was found in netsurf 2.9 and 2.8 releases.

This caused me to not trust alloca.

Please commit, thanks.

Greets,
Ole

No comments:

Post a Comment