[netsurf-dev] Re: [PATCH] libcss SVG properties fill, stroke and stroke-width

Hi Michael,

I am happy that this benefits you as well.

To provide some background, my own interest in libCSS is to implement
an "SVG agent" using Cairo and libxml2 with the final purpose of
embedding
the agent as a video game GUI[0].

With opacity, fill-opacity, stroke-opacity, fill, stroke and
stroke-witdth
is enough for me to render the iconic tiger.svg, but I am still far from
a MVP,
so that's why I may be adding more in the future. For now I need to
focus on some attributes,
viewBox for example and add some I/O to get to get to MVP.

Anyway, thanks for testing!

[0] https://github.com/AeonGames/AeonGUI

On 2024-05-02 18:22, Michael Orlitzky wrote:
> On Thu, 2024-05-02 at 17:20 -0600, Rodrigo Hernandez wrote:
>> Hello,
>>
>> The attached patch adds SVG properties fill, stroke and stroke-width
>> as
>> well as some basic tests to libCSS.
>>
>> I noticed that fill and stroke opacity were recently added, and I will
>> likely be adding more SVG related properties as needed,
>> Let me know if there is already an active effort to add more SVG props
>> not to duplicate any work.
>
> Thanks for doing this. My main motivation for adding SVG support to
> libcss (and CSS support to libsvgtiny) is to eventually use libsvgtiny
> as a non-rust replacement for librsvg in GTK. For that we need only two
> things[0],
>
> 1. <style> support in libsvgtiny via libcss
> 2. "fill" support in libcss
>
> I've done (1), and your patch should take care of (2). So thanks. I'll
> test it out when I can.
>
>
> [0]
> https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gdktextureutils.c#L224