Re: libcss fill- and stroke-opacity

On 19/09/2023 23:28, Michael Orlitzky wrote:
> As promised, here's my libcss branch adding the SVG fill- and
> stroke-opacity properties. HTTPS also works but the cert is
> self-signed pending a new release of apache; its SHA1 fingerprint is
> C8:01:8B:A6:3A:07:C0:65:AF:F0:CB:17:5F:A3:B5:9F:5B:D0:FC:E0.
>
> http://gitweb.michael.orlitzky.com/libcss.git fill-stroke-opacity
>
> Here's a summary of the changes. The commits are probably a bit too
> fine-grained but it makes them easy to reorder and amend. I did my
> best to keep the test suite passing for as long as possible.

[snip]

Looks good to me, thanks. One minor thing (that you inherited from the
existing opacity implementation) is the bogus use of CSS_Z_INDEX_SET in
the cascade for these properties. I've fixed that for the opacity property.

I'll tidy that while merging -- I'm going to squash your changes down to
a pair of commits -- one for each new property (but I very much
appreciate the fine granularity of the series -- very easy to review).


J.
_______________________________________________
netsurf-dev mailing list -- netsurf-dev@netsurf-browser.org
To unsubscribe send an email to netsurf-dev-leave@netsurf-browser.org