Re: [gccsdk] __sync_lock_test_and_set bug fix

On Nov 8 2022, at 10:28 am, Cameron Cawley <ccawley2011@gmail.com> wrote:

> Attached is a patch that fixes the implementation of
> __sync_lock_test_and_set in non-EABI toolchains. Previously, __cmpxchg
> would return the previous value instead of a failure code, which would
> result in an endless loop if the previous value is non-zero.
> Implementations have also been provided for 1, 2 and 8 byte types.
>
> A test program has also been attached which demonstrates the issue.

Thanks for this. This one is a bit beyond my pay grade but it seems to
make sense. In the absence of any other comment I've committed it as r7724.

I'm not sure what's best to do with your test program? It might be nice
to go in a GCCSDK test suite, if only we had one of those...

Theo


_______________________________________________
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK