On Sat, 12 Mar 2022 at 20:46, Theo Markettos <theo@markettos.org.uk> wrote:
On the patch to the autobuilder scripts, I see there are some changes to
fetch-program and setvars-template, mostly removing code. Are those
necessary for your patch, or are they stray changes in your tree? Just
wanted to make sure they're not going to affect other autobuilder packages
that do use them (they look like they're to do with SVN support, which I'm
sure other packages use). If you're just refactoring the existing code and
the outcome is the same then that's fine.
According to grep, the desklib and desklib-scl recipes were the only ones that used AB_SVN_AOF, and the comments in fetch-program state "AB_SVN_AOF support is only temporary", so it made sense to remove it. It isn't required, though, and the rest of the patch can be applied without the fetch-program changes.
Regards
Cameron
No comments:
Post a Comment