Re: Saving Choices

On 11 August 2015 11:16:38 BST, Brian Jordan <brian.jordan9@btinternet.com> wrote:
>In article <c45a69f154.gavin@wra1th.plus.com>,
> Gavin Wraith <gavin@wra1th.plus.com> wrote:
>> I have noticed that "Disable JavaScript" appears not to be saved
>> in <Choices$Write>.WWW.NetSurf.Choices. Is that right?
>> Using NS 3.4 #2876
>
>That seems to be the case.
>
>>From the Jenkins changes log:
>
>#2872 (9th August)
>
>"2. Permanently enable display of the 'enable javascript UI options'"
>
>Does this mean that on other platforms there is now a javascript on/off
>button or menu option which does away with the need to permanently save
>this preference? If so maybe this won't work in the RISC OS version
>until
>the UI is updated. Only guessing.

That's not relevant to your issue. In the Amiga frontend the "Enable JavaScript" toggles only displayed if NetSurf was built with JavaScript enabled. Now the JavaScript engine has changed, the conditionals weren't working, so I took the decision to remove them. There's no particular reason to disable JavaScript in the build as it doesn't involve building external libraries.

The setting should be saved. I believe it is an intentional feature that it is enabled on startup whilst the new JavaScript engine is integrated, so once that is complete it will start working again.

Chris