[PATCH] Fixes #2101, evaluation of text field and textarea line height.

---
desktop/textarea.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/desktop/textarea.c b/desktop/textarea.c
index bd35a5e..2ba0982 100644
--- a/desktop/textarea.c
+++ b/desktop/textarea.c
@@ -1895,9 +1895,9 @@ struct textarea *textarea_create(const textarea_flags flags,
ret->show = &ret->text;
}

- ret->line_height = FIXTOINT(FDIV((FMUL(FLTTOFIX(1.3),
- FMUL(nscss_screen_dpi, INTTOFIX((setup->text.size))))),
- FONT_SIZE_SCALE * F_72));
+ ret->line_height = FIXTOINT(FMUL(FLTTOFIX(1.3), FDIV(FMUL(
+ nscss_screen_dpi, FDIV(INTTOFIX(setup->text.size),
+ INTTOFIX(FONT_SIZE_SCALE))), F_72)));

ret->caret_pos.line = ret->caret_pos.byte_off = -1;
ret->caret_x = 0;
--
1.8.3.2

[PATCH] Fixes #2101, evaluation of text field and textarea line height.

Repo : netsurf
#sURL : https://github.com/Achal-Aggarwal/netsurf.git
#sRef : fix-line-height
#SHA1 : 763825e5972f6ea7f986056f84a68cec451ba7cb
#Land : master
#link : https://github.com/Achal-Aggarwal/netsurf/tree/fix-line-height
#bugtracker : http://bugs.netsurf-browser.org/mantis/view.php?id=2101


#Description
It fixes the formula of evaluation of line height of textarea field.

Prev. patch (not required now) : http://comments.gmane.org/gmane.comp.web.netsurf.devel/9988

Achal-Aggarwal (1):
Fixes #2101, evaluation of text field and textarea line height.

desktop/textarea.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

--
1.8.3.2

Re: NetSurf 3.1 Change Log

On 01/04/2014 09:16, Michael Drake wrote:
>
> http://www.netsurf-browser.org/temp/ChangeLog.txt
>
> Anyone see anything wrong/missing?

Looks good for my part.

I just checked that HEAD still builds on Haiku.

François.

Re: Version 1773

In article <53f177d568chris@chris-johnson.org.uk>,
cj <chris@chris-johnson.org.uk> wrote:
> I may know something later on today.

OK. I now have the Iyonix running a relatively clean boot from 30th
Mar, and RISC OS v. 5.21 30th Mar. Netsurf #1772 is now running fine
(that's the latest I have on the Iyo at the moment). Will download
and upgrade to #1774 (or later if available), and check that is ok as
well. A lot more stuff still to get back in to !Boot, so keeping
fingers crossed.

Whether I will ever find out what in !Boot was causing the problem I
doubt.

Anyway, thanks for the help, chaps, especially Ron for showing I
wasn't totally mad!

--
Chris Johnson

Re: Version 1773

In article <53f13a8c7eron.briscoe@blueyonder.co.uk>,
Ron Briscoe <ron.briscoe@blueyonder.co.uk> wrote:

> I took a picture of the error box ;-). Thus.

> ----------------------------------------------------------------------------------------------------------
> Error 0x80000005: Internal error: branch through zero
> pc: fffffffc

> Fatal signal received: EMT trap

> Stack backtrace:
> Running thread 0x6153a4
> ( 61df7c) pc: 478d28 1r: 4729b0 sp: 61df80 _write_backtrace()
> ( 61dfe4) pc: 478e4c 1r: 4799ac sp: 61dfe8 _unixlib_raise_signal()
> ( 61dff4) pc: 4798e0 1r: 48c9bc sp: 61cf10 UnixLibErrorHandler()
> (fb4213e2) pc: 421ae92c 1r: bea00 sp: 680010
> UnixLib detected recursion of signal SIGSEGV. Exiting.

> Press Space or click mouse to continue
> --------------------------------------------------------------------


That is the same that I still get ... but I am now on the 30th Mar
versions of OS and Boot. I am in the process of constructing a clean
!Boot based on the 30th Mar, putting back in the minimum needed to
get the machine booted, and Netsurf running (or not).

I may know something later on today.

--
Chris Johnson

Re: Version 1773

Gavin Wraith wrote

> NetSurf #1773 on Raspberry Pi 5.21. Pressing F8 or selecting
> Page->View Source... works OK on local webpages. Otherwise
> selecting Page->View Source... yields an error message
> "NetSurf is running out of memory ..." and pressing F8 yields
> "An unexpected error occurred: Not found".


NetSurf #1774 on RasPi 5.21. Pressing F8 or Page->View Source...
gives error message "NetSurf is running out of memory ..."
for all webpages (inc local)

No problem on Iyonix (5.20) with NetSurf #1774

John



--
John Rickman - http://rickman.orpheusweb.co.uk/lynx
"Poetry is a MUG's game" - TS Eliot

NetSurf 3.1 Change Log

http://www.netsurf-browser.org/temp/ChangeLog.txt

Anyone see anything wrong/missing?

Cheers,

Michael