I apologise for how long this has taken to do, I have been very tired :-(
Firstly, well done on getting git send-email to work :-)
> diff --git a/include/dom/dom.h b/include/dom/dom.h
> index 2ef6e9b..d34f27f 100644
> --- a/include/dom/dom.h
> +++ b/include/dom/dom.h
> @@ -55,6 +55,7 @@
> #include <dom/html/html_option_element.h>
> #include <dom/html/html_select_element.h>
> #include <dom/html/html_options_collection.h>
> +#include <dom/html/html_hr_element.h>
You've not moved this anywhere and also not told me why you put it in this
position.
> diff --git a/include/dom/html/html_hr_element.h b/include/dom/html/html_hr_element.h
> * Copyright 2009 Bo Yang <struggleyb.nku@gmail.com>
> + * Copyright 2014 Rupinder Singh Khokhar <rsk1coder99@gmail.com>
Much better :-)
> +dom_exception dom_html_h_r_element_get_no_shade(
> + dom_html_h_r_element *ele, bool *no_shade);
The no_shade is good, but I'm slightly confused as to why you're putting
dom_html_h_r_element rather than dom_html_hr_element -- does our conversion
algorithm really expect it this way?
[snip rest]
If the test suite really does expect dom_html_h_r_element then I guess I can
accept this patch for now, but overall, I think I'd prefer it if it could be
dom_html_hr_element -- Perhaps John Mark will have some useful input here?
D.
--
Daniel Silverstone http://www.netsurf-browser.org/
PGP mail accepted and encouraged. Key Id: 3CCE BABE 206C 3B69
Wednesday, 5 March 2014
Tuesday, 4 March 2014
Re: [gccsdk] GCC 4.7.4 Rel 1 Dev 2014-01-08: initial comments and feedback.
On 04/03/14 11:51, Duncan Moore wrote:
>
> On 03/03/2014 20:39, Lee Noar wrote:
>> The loop control instructions are missing as well as the function
>> epilogue; the compiler knew it was creating an infinite loop.
>>
>> I assume you built the compiler yourself on the 8th January?
>
> No. I'm using
> http://www.riscos.info/downloads/gccsdk/testing/4.7.4/gccsdk-gcc-src-4.7.4-Rel1dev.tar.bz2.
>
>
>> So
>> you have a cross compiler?
>
> No.
Ah, ok. I'll build an updated version and see if the problem is still
there. If it's fixed I'll ask John to update the download. If it's
still there, I'll have to figure out when and why it went wrong.
Thanks,
Lee.
_______________________________________________
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK
>
> On 03/03/2014 20:39, Lee Noar wrote:
>> The loop control instructions are missing as well as the function
>> epilogue; the compiler knew it was creating an infinite loop.
>>
>> I assume you built the compiler yourself on the 8th January?
>
> No. I'm using
> http://www.riscos.info/downloads/gccsdk/testing/4.7.4/gccsdk-gcc-src-4.7.4-Rel1dev.tar.bz2.
>
>
>> So
>> you have a cross compiler?
>
> No.
Ah, ok. I'll build an updated version and see if the problem is still
there. If it's fixed I'll ask John to update the download. If it's
still there, I'll have to figure out when and why it went wrong.
Thanks,
Lee.
_______________________________________________
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK
Re: [gccsdk] GCC 4.7.4 Rel 1 Dev 2014-01-08: initial comments and feedback.
On 03/03/2014 20:39, Lee Noar wrote:
> The loop control instructions are missing as well as the function
> epilogue; the compiler knew it was creating an infinite loop.
>
> I assume you built the compiler yourself on the 8th January?
No. I'm using
http://www.riscos.info/downloads/gccsdk/testing/4.7.4/gccsdk-gcc-src-4.7.4-Rel1dev.tar.bz2.
> So
> you have a cross compiler?
No.
Regards
Duncan
_______________________________________________
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK
> The loop control instructions are missing as well as the function
> epilogue; the compiler knew it was creating an infinite loop.
>
> I assume you built the compiler yourself on the 8th January?
No. I'm using
http://www.riscos.info/downloads/gccsdk/testing/4.7.4/gccsdk-gcc-src-4.7.4-Rel1dev.tar.bz2.
> So
> you have a cross compiler?
No.
Regards
Duncan
_______________________________________________
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK
[gccsdk] fgets problem/Unixlib
On GCC 4.1.2/Unixlib, running on a Raspberry Pi, fgets() does not appear to work. It returns NULL when there is data in the file to read. It makes no difference whether the code is statically or dynamically linked, but the shared C library version works fine with exactly the same data file.
--
David Gee
See https://www.riscosopen.org/forum/forums/11/topics/2447 for further details.
David Gee
Monday, 3 March 2014
Re: [gccsdk] GCC 4.7.4 Rel 1 Dev 2014-01-08: initial comments and feedback.
On 02/03/14 16:05, Duncan Moore wrote:>
> On 02/03/2014 12:39, Lee Noar wrote:
>> Perhaps if you email me your a/out binary I can try it here and see if
>> I get the same result and I can compare it against mine.
>
> The zip file has 4 binaries - one for each of no optimisation, -O1, -O2
> and -O3.
>
>> would the ELF help?
>>
>> The ELF? I'm not sure what you're referring to there.
>
> I meant the a/out binary, of filetype ELF!
Doh! Of course, seems obvious now :-)
Well, I see the problem in your binary now and it's a bit odd.
This is what my main looks like:
00000484 : FF000008 : ; func: main
00000488 : E1A0C00D : MOV R12,R13
0000048C : E92DD810 : STMDB R13!,{R4,R11,R12,R14,PC}
00000490 : E24CB004 : SUB R11,R12,#4
00000494 : E15D000A : CMP R13,R10
00000498 : BBFFFFEB : BLLT &0000044C
0000049C : E3A04000 : MOV R4,#0
000004A0 : E1A01004 : MOV R1,R4
000004A4 : E59F0014 : LDR R0,&000004C0
000004A8 : E2844001 : ADD R4,R4,#1
000004AC : EBFFFFEC : BL &00000464
000004B0 : E3540006 : CMP R4,#6
000004B4 : 1AFFFFF9 : BNE &000004A0
000004B8 : E3A00000 : MOV R0,#0
000004BC : E91BA810 : LDMDB R11,{R4,R11,R13,PC}
000004C0 : 000087C0 : ANDEQ R8,R0,R0,ASR #15
000004C4 : E59F3010 : LDR R3,&000004DC
000004C8 : E583000C : STR R0,[R3,#12]
000004CC : E583101C : STR R1,[R3,#28]
000004D0 : E5832020 : STR R2,[R3,#32]
000004D4 : E1A00003 : MOV R0,R3
000004D8 : EAFFFFDE : B &00000458
000004DC : 000088A8 : ANDEQ R8,R0,R8,LSR #17
and this is what yours looks like:
00000484 : FF000008 : ; func: main
00000488 : E1A0C00D : MOV R12,R13
0000048C : E92DD810 : STMDB R13!,{R4,R11,R12,R14,PC}
00000490 : E15D000A : CMP R13,R10
00000494 : BBFFFFF2 : BLLT &00000464
00000498 : E3A04000 : MOV R4,#0
0000049C : E1A01004 : MOV R1,R4
000004A0 : E59F0008 : LDR R0,&000004B0
000004A4 : EBFFFFE8 : BL &0000044C
000004A8 : E2844001 : ADD R4,R4,#1
000004AC : EAFFFFFA : B &0000049C
000004B0 : 000087B0 : Undefined instruction
000004B4 : E59F3010 : LDR R3,&000004CC
000004B8 : E583000C : STR R0,[R3,#12]
000004BC : E583101C : STR R1,[R3,#28]
000004C0 : E5832020 : STR R2,[R3,#32]
000004C4 : E1A00003 : MOV R0,R3
000004C8 : EAFFFFDC : B &00000440
000004CC : 00008898 : Undefined instruction
The loop control instructions are missing as well as the function
epilogue; the compiler knew it was creating an infinite loop.
I assume you built the compiler yourself on the 8th January? So
you have a cross compiler? Could try with the cross compiler to
see if that gives the same result please.
I'm beginning to think that someone committed a change upstream
that broke the compiler and you were unlucky enough to check it
out. I'm on upstream revision 206333 and you are on 206442,
so if that's the case it happened between the two - they may
even have fixed already.
Perhaps you could try upgrading your GCC source tree and
rebuilding.
Thanks,
Lee.
_______________________________________________
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK
> On 02/03/2014 12:39, Lee Noar wrote:
>> Perhaps if you email me your a/out binary I can try it here and see if
>> I get the same result and I can compare it against mine.
>
> The zip file has 4 binaries - one for each of no optimisation, -O1, -O2
> and -O3.
>
>> would the ELF help?
>>
>> The ELF? I'm not sure what you're referring to there.
>
> I meant the a/out binary, of filetype ELF!
Doh! Of course, seems obvious now :-)
Well, I see the problem in your binary now and it's a bit odd.
This is what my main looks like:
00000484 : FF000008 : ; func: main
00000488 : E1A0C00D : MOV R12,R13
0000048C : E92DD810 : STMDB R13!,{R4,R11,R12,R14,PC}
00000490 : E24CB004 : SUB R11,R12,#4
00000494 : E15D000A : CMP R13,R10
00000498 : BBFFFFEB : BLLT &0000044C
0000049C : E3A04000 : MOV R4,#0
000004A0 : E1A01004 : MOV R1,R4
000004A4 : E59F0014 : LDR R0,&000004C0
000004A8 : E2844001 : ADD R4,R4,#1
000004AC : EBFFFFEC : BL &00000464
000004B0 : E3540006 : CMP R4,#6
000004B4 : 1AFFFFF9 : BNE &000004A0
000004B8 : E3A00000 : MOV R0,#0
000004BC : E91BA810 : LDMDB R11,{R4,R11,R13,PC}
000004C0 : 000087C0 : ANDEQ R8,R0,R0,ASR #15
000004C4 : E59F3010 : LDR R3,&000004DC
000004C8 : E583000C : STR R0,[R3,#12]
000004CC : E583101C : STR R1,[R3,#28]
000004D0 : E5832020 : STR R2,[R3,#32]
000004D4 : E1A00003 : MOV R0,R3
000004D8 : EAFFFFDE : B &00000458
000004DC : 000088A8 : ANDEQ R8,R0,R8,LSR #17
and this is what yours looks like:
00000484 : FF000008 : ; func: main
00000488 : E1A0C00D : MOV R12,R13
0000048C : E92DD810 : STMDB R13!,{R4,R11,R12,R14,PC}
00000490 : E15D000A : CMP R13,R10
00000494 : BBFFFFF2 : BLLT &00000464
00000498 : E3A04000 : MOV R4,#0
0000049C : E1A01004 : MOV R1,R4
000004A0 : E59F0008 : LDR R0,&000004B0
000004A4 : EBFFFFE8 : BL &0000044C
000004A8 : E2844001 : ADD R4,R4,#1
000004AC : EAFFFFFA : B &0000049C
000004B0 : 000087B0 : Undefined instruction
000004B4 : E59F3010 : LDR R3,&000004CC
000004B8 : E583000C : STR R0,[R3,#12]
000004BC : E583101C : STR R1,[R3,#28]
000004C0 : E5832020 : STR R2,[R3,#32]
000004C4 : E1A00003 : MOV R0,R3
000004C8 : EAFFFFDC : B &00000440
000004CC : 00008898 : Undefined instruction
The loop control instructions are missing as well as the function
epilogue; the compiler knew it was creating an infinite loop.
I assume you built the compiler yourself on the 8th January? So
you have a cross compiler? Could try with the cross compiler to
see if that gives the same result please.
I'm beginning to think that someone committed a change upstream
that broke the compiler and you were unlucky enough to check it
out. I'm on upstream revision 206333 and you are on 206442,
so if that's the case it happened between the two - they may
even have fixed already.
Perhaps you could try upgrading your GCC source tree and
rebuilding.
Thanks,
Lee.
_______________________________________________
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK
[PATCH] implementation of hr tag in libdom
---
Makefile | 1 +
include/dom/dom.h | 1 +
include/dom/html/html_hr_element.h | 34 ++++
src/html/Makefile | 4 +-
src/html/TODO | 2 +-
src/html/html_document.c | 4 +
src/html/html_document_strings.h | 1 +
src/html/html_hr_element.c | 184 +++++++++++++++++++++
src/html/html_hr_element.h | 45 +++++
.../tests/level1/html/HTMLHRElement01.xml | 42 +++++
.../tests/level1/html/HTMLHRElement01.xml.kfail | 42 -----
.../tests/level1/html/HTMLHRElement02.xml | 43 +++++
.../tests/level1/html/HTMLHRElement02.xml.kfail | 43 -----
.../tests/level1/html/HTMLHRElement03.xml | 42 +++++
.../tests/level1/html/HTMLHRElement03.xml.kfail | 42 -----
.../tests/level1/html/HTMLHRElement04.xml | 42 +++++
.../tests/level1/html/HTMLHRElement04.xml.kfail | 42 -----
17 files changed, 442 insertions(+), 172 deletions(-)
create mode 100644 test/testcases/tests/level1/html/HTMLHRElement01.xml
delete mode 100644 test/testcases/tests/level1/html/HTMLHRElement01.xml.kfail
create mode 100644 test/testcases/tests/level1/html/HTMLHRElement02.xml
delete mode 100644 test/testcases/tests/level1/html/HTMLHRElement02.xml.kfail
create mode 100644 test/testcases/tests/level1/html/HTMLHRElement03.xml
delete mode 100644 test/testcases/tests/level1/html/HTMLHRElement03.xml.kfail
create mode 100644 test/testcases/tests/level1/html/HTMLHRElement04.xml
delete mode 100644 test/testcases/tests/level1/html/HTMLHRElement04.xml.kfail
diff --git a/Makefile b/Makefile
index 7c50cad..3aac0c3 100644
--- a/Makefile
+++ b/Makefile
@@ -96,6 +96,7 @@ INSTALL_ITEMS := $(INSTALL_ITEMS) $(I):$(Is)/html_text_area_element.h
INSTALL_ITEMS := $(INSTALL_ITEMS) $(I):$(Is)/html_option_element.h
INSTALL_ITEMS := $(INSTALL_ITEMS) $(I):$(Is)/html_opt_group_element.h
INSTALL_ITEMS := $(INSTALL_ITEMS) $(I):$(Is)/html_options_collection.h
+INSTALL_ITEMS := $(INSTALL_ITEMS) $(I):$(Is)/html_hr_element.h
INSTALL_ITEMS := $(INSTALL_ITEMS) /$(LIBDIR)/pkgconfig:lib$(COMPONENT).pc.in
INSTALL_ITEMS := $(INSTALL_ITEMS) /$(LIBDIR):$(OUTPUT)
diff --git a/include/dom/dom.h b/include/dom/dom.h
index 2ef6e9b..d34f27f 100644
--- a/include/dom/dom.h
+++ b/include/dom/dom.h
@@ -55,6 +55,7 @@
#include <dom/html/html_option_element.h>
#include <dom/html/html_select_element.h>
#include <dom/html/html_options_collection.h>
+#include <dom/html/html_hr_element.h>
/* DOM Events header */
#include <dom/events/events.h>
diff --git a/include/dom/html/html_hr_element.h b/include/dom/html/html_hr_element.h
index 2e182d5..638154f 100644
--- a/include/dom/html/html_hr_element.h
+++ b/include/dom/html/html_hr_element.h
@@ -3,5 +3,39 @@
* Licensed under the MIT License,
* http://www.opensource.org/licenses/mit-license.php
* Copyright 2009 Bo Yang <struggleyb.nku@gmail.com>
+ * Copyright 2014 Rupinder Singh Khokhar <rsk1coder99@gmail.com>
*/
+#ifndef dom_html_hr_element_h_
+#define dom_html_hr_element_h_
+#include <stdbool.h>
+#include <dom/core/exceptions.h>
+#include <dom/core/string.h>
+
+typedef struct dom_html_h_r_element dom_html_h_r_element;
+
+dom_exception dom_html_h_r_element_get_no_shade(
+ dom_html_h_r_element *ele, bool *no_shade);
+
+dom_exception dom_html_h_r_element_set_no_shade(
+ dom_html_h_r_element *ele, bool no_shade);
+
+dom_exception dom_html_h_r_element_get_align(
+ dom_html_h_r_element *element, dom_string **align);
+
+dom_exception dom_html_h_r_element_set_align(
+ dom_html_h_r_element *element, dom_string *align);
+
+dom_exception dom_html_h_r_element_get_size(
+ dom_html_h_r_element *element, dom_string **size);
+
+dom_exception dom_html_h_r_element_set_size(
+ dom_html_h_r_element *ele, dom_string *size);
+
+dom_exception dom_html_h_r_element_get_width(
+ dom_html_h_r_element *ele, dom_string **width);
+
+dom_exception dom_html_h_r_element_set_width(
+ dom_html_h_r_element *ele, dom_string *width);
+
+
Makefile | 1 +
include/dom/dom.h | 1 +
include/dom/html/html_hr_element.h | 34 ++++
src/html/Makefile | 4 +-
src/html/TODO | 2 +-
src/html/html_document.c | 4 +
src/html/html_document_strings.h | 1 +
src/html/html_hr_element.c | 184 +++++++++++++++++++++
src/html/html_hr_element.h | 45 +++++
.../tests/level1/html/HTMLHRElement01.xml | 42 +++++
.../tests/level1/html/HTMLHRElement01.xml.kfail | 42 -----
.../tests/level1/html/HTMLHRElement02.xml | 43 +++++
.../tests/level1/html/HTMLHRElement02.xml.kfail | 43 -----
.../tests/level1/html/HTMLHRElement03.xml | 42 +++++
.../tests/level1/html/HTMLHRElement03.xml.kfail | 42 -----
.../tests/level1/html/HTMLHRElement04.xml | 42 +++++
.../tests/level1/html/HTMLHRElement04.xml.kfail | 42 -----
17 files changed, 442 insertions(+), 172 deletions(-)
create mode 100644 test/testcases/tests/level1/html/HTMLHRElement01.xml
delete mode 100644 test/testcases/tests/level1/html/HTMLHRElement01.xml.kfail
create mode 100644 test/testcases/tests/level1/html/HTMLHRElement02.xml
delete mode 100644 test/testcases/tests/level1/html/HTMLHRElement02.xml.kfail
create mode 100644 test/testcases/tests/level1/html/HTMLHRElement03.xml
delete mode 100644 test/testcases/tests/level1/html/HTMLHRElement03.xml.kfail
create mode 100644 test/testcases/tests/level1/html/HTMLHRElement04.xml
delete mode 100644 test/testcases/tests/level1/html/HTMLHRElement04.xml.kfail
diff --git a/Makefile b/Makefile
index 7c50cad..3aac0c3 100644
--- a/Makefile
+++ b/Makefile
@@ -96,6 +96,7 @@ INSTALL_ITEMS := $(INSTALL_ITEMS) $(I):$(Is)/html_text_area_element.h
INSTALL_ITEMS := $(INSTALL_ITEMS) $(I):$(Is)/html_option_element.h
INSTALL_ITEMS := $(INSTALL_ITEMS) $(I):$(Is)/html_opt_group_element.h
INSTALL_ITEMS := $(INSTALL_ITEMS) $(I):$(Is)/html_options_collection.h
+INSTALL_ITEMS := $(INSTALL_ITEMS) $(I):$(Is)/html_hr_element.h
INSTALL_ITEMS := $(INSTALL_ITEMS) /$(LIBDIR)/pkgconfig:lib$(COMPONENT).pc.in
INSTALL_ITEMS := $(INSTALL_ITEMS) /$(LIBDIR):$(OUTPUT)
diff --git a/include/dom/dom.h b/include/dom/dom.h
index 2ef6e9b..d34f27f 100644
--- a/include/dom/dom.h
+++ b/include/dom/dom.h
@@ -55,6 +55,7 @@
#include <dom/html/html_option_element.h>
#include <dom/html/html_select_element.h>
#include <dom/html/html_options_collection.h>
+#include <dom/html/html_hr_element.h>
/* DOM Events header */
#include <dom/events/events.h>
diff --git a/include/dom/html/html_hr_element.h b/include/dom/html/html_hr_element.h
index 2e182d5..638154f 100644
--- a/include/dom/html/html_hr_element.h
+++ b/include/dom/html/html_hr_element.h
@@ -3,5 +3,39 @@
* Licensed under the MIT License,
* http://www.opensource.org/licenses/mit-license.php
* Copyright 2009 Bo Yang <struggleyb.nku@gmail.com>
+ * Copyright 2014 Rupinder Singh Khokhar <rsk1coder99@gmail.com>
*/
+#ifndef dom_html_hr_element_h_
+#define dom_html_hr_element_h_
+#include <stdbool.h>
+#include <dom/core/exceptions.h>
+#include <dom/core/string.h>
+
+typedef struct dom_html_h_r_element dom_html_h_r_element;
+
+dom_exception dom_html_h_r_element_get_no_shade(
+ dom_html_h_r_element *ele, bool *no_shade);
+
+dom_exception dom_html_h_r_element_set_no_shade(
+ dom_html_h_r_element *ele, bool no_shade);
+
+dom_exception dom_html_h_r_element_get_align(
+ dom_html_h_r_element *element, dom_string **align);
+
+dom_exception dom_html_h_r_element_set_align(
+ dom_html_h_r_element *element, dom_string *align);
+
+dom_exception dom_html_h_r_element_get_size(
+ dom_html_h_r_element *element, dom_string **size);
+
+dom_exception dom_html_h_r_element_set_size(
+ dom_html_h_r_element *ele, dom_string *size);
+
+dom_exception dom_html_h_r_element_get_width(
+ dom_html_h_r_element *ele, dom_string **width);
+
+dom_exception dom_html_h_r_element_set_width(
+ dom_html_h_r_element *ele, dom_string *width);
+
+
Sunday, 2 March 2014
Re: Yahoo groups
Am Sonntag, den 02.03.2014, 11:43 +0100 schrieb Peter Slegg
<p.slegg@scubadivers.co.uk>:
> I have accessed Yahoo groups before but when I tried just to open
> various pages I keep getting the error:
>
> Unable to fetch document
>
> I am using version Atari 1741
Did you:
- enable verbose log
- enable curl debug output (not sure if there is still an option for
it)
- does it also happen with a previous release?
Maybe yahoo changed something ;)
Greets
<p.slegg@scubadivers.co.uk>:
> I have accessed Yahoo groups before but when I tried just to open
> various pages I keep getting the error:
>
> Unable to fetch document
>
> I am using version Atari 1741
Did you:
- enable verbose log
- enable curl debug output (not sure if there is still an option for
it)
- does it also happen with a previous release?
Maybe yahoo changed something ;)
Greets
Subscribe to:
Posts (Atom)