Re: [Patch] Add support for parsing writing-mode property v1

On Fri, 2013-06-07 at 04:09 -0400, Caitlin Potter wrote:
> This patch is intended to support the parsing and storage of the
> "writing-mode" property, which is one of the building blocks for
> vertical text in css (support for which is currently required by the
> HTML5 track element and obviously is a pretty important localization
> feature -- and just simply looks cool, too).

Excellent. Thanks for your work on this.

[...]

> It is quite likely that there are things substantially wrong,
> including the lack of test data (I haven't figured out how to get the
> test suite to even build and run yet, `make test` seems to fail
> substantially here.)

You're using a Mac, right? I've no current idea why make test isn't
working for you on that platform, as the test infrastructure is pretty
trivial. We're investigating that now.

> So some review would be good, I'd like to get this approved by netsurf
> devs before trying to squeeze it into mozilla-servo.

In general, this looks fine to me (modulo the lack of test data, which
you've mentioned above). There are a few minor whitespace nits, which
can be fixed when we merge the change in. Additionally, there's a stray
commented-out chunk in css__set_writing_mode_from_hint. This, too is
trivially fixed, so I'm not concerned by it.


J.

[Patch] Add support for parsing writing-mode property v1

This patch is intended to support the parsing and storage of the "writing-mode" property, which is one of the building blocks for vertical text in css (support for which is currently required by the HTML5 track element and obviously is a pretty important localization feature -- and just simply looks cool, too).

The layout side of things can be dealt with elsewhere, but first and foremost is getting libcss to support the property.

A link to the current draft is here http://dev.w3.org/csswg/css-writing-modes/ with the writing-mode property in particular described in http://dev.w3.org/csswg/css-writing-modes/#writing-mode

===

It is quite likely that there are things substantially wrong, including the lack of test data (I haven't figured out how to get the test suite to even build and run yet, `make test` seems to fail substantially here.)

So some review would be good, I'd like to get this approved by netsurf devs before trying to squeeze it into mozilla-servo.

Any and all feedback is much appreciated, thanks a bunch.

Re: Visited links

On 6 Jun 2013 Rob Kendrick wrote:

> On Thu, Jun 06, 2013 at 11:03:25AM +0100, Richard Porter wrote:
>> I've noticed that since quite recently NS has been preserving visited
>> link status over several sessions instead of starting from scratch
>> each time.

> This has always been the case. A link is "visited" if it is in the
> history (or rather, in the urldb with a non-zero "visited" count.)

> The only recent change is that we re-enabled the code to colour links
> differently if they had a non-zero visited count.

Thanks, that explains why I have just noticed it.

--
Richard Porter http://www.minijem.plus.com/
mailto:ricp@minijem.plus.com
I don't want a "user experience" - I just want stuff that works.

Re: Visited links

On Thu, Jun 06, 2013 at 11:03:25AM +0100, Richard Porter wrote:
> I've noticed that since quite recently NS has been preserving visited
> link status over several sessions instead of starting from scratch
> each time.

This has always been the case. A link is "visited" if it is in the
history (or rather, in the urldb with a non-zero "visited" count.)

The only recent change is that we re-enabled the code to colour links
differently if they had a non-zero visited count.

B.

Visited links

I've noticed that since quite recently NS has been preserving visited
link status over several sessions instead of starting from scratch
each time. Is this related to the site history duration in the
Security choices?

--
Richard Porter http://www.minijem.plus.com/
mailto:ricp@minijem.plus.com
I don't want a "user experience" - I just want stuff that works.

Re: [Rpcemu] Networking: an interesting discovery (I think)

In message <0208af5653.old_coaster@old_coaster.yahoo.co.uk>
Tony Moore <old_coaster@yahoo.co.uk> wrote:

> On 4 Jun 2013, george greenfield <george.greenfield@tiscali.co.uk>
> wrote:
>> In message <20130604155952.6078224C4A@orac.inputplus.co.uk> you wrote:
[snip]
>
> C:\Program Files\RPCEmu\rpclog.txt is written automatically every time
> RPCEmu 0.8.10 starts.
>
> There won't be a copy in the distribution zipfile, because RPCEmu has
> not been run, whilst still in the archive.
>
> Tony

Thanks, Tony: live and learn!

George
--
george greenfield

_______________________________________________
Rpcemu mailing list
Rpcemu@riscos.info
http://www.riscos.info/cgi-bin/mailman/listinfo/rpcemu

Re: [Rpcemu] Networking: an interesting discovery (I think)

On 4 Jun 2013, george greenfield <george.greenfield@tiscali.co.uk>
wrote:
> In message <20130604155952.6078224C4A@orac.inputplus.co.uk> you wrote:

[snip]

> > Don't know if this has already been attempted, but how about saving
> > off the log file, rpclog.txt?, after each of these attempts so you
> > or others can see if their differences explain why? If not, it
> > suggests more logging is required in some areas to catch problems in
> > the field.
>
> I would do, but there was no rpclog.txt file in my Zip of 0.8.10 (see
> attached screenshot - forwarded to Ralph separately). My 0.8.9
> installation does have one, so I'll save it next time I hit problems.
> It would be handy for 0.8.10 as well...

C:\Program Files\RPCEmu\rpclog.txt is written automatically every time
RPCEmu 0.8.10 starts.

There won't be a copy in the distribution zipfile, because RPCEmu has
not been run, whilst still in the archive.

Tony

_______________________________________________
Rpcemu mailing list
Rpcemu@riscos.info
http://www.riscos.info/cgi-bin/mailman/listinfo/rpcemu